feat: update active theme to 'valua' and modify Waybar clock format#2
Merged
feat: update active theme to 'valua' and modify Waybar clock format#2
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the system theme configuration and modifies the Waybar clock display format. The changes switch the active theme from "dracula" to "valua" and implement a more detailed clock format with real-time updates.
- Changed active theme from "dracula" to "valua"
- Updated Waybar clock to show time-only format by default with detailed alternate format
- Added 1-second interval for real-time clock updates
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| flake.nix | Updates active theme selection from dracula to valua |
| modules/hyprland/waybar.nix | Modifies clock format, adds seconds to alternate format, and enables 1-second updates |
| format-alt = " {:%d/%m}"; | ||
| format = "{:%H:%M}"; | ||
| format-alt = " {:%a, %d %m, %H:%M:%S}"; | ||
| interval = 1; |
There was a problem hiding this comment.
The clock format was simplified to show only hours and minutes, but the interval is set to 1 second on line 239. This creates unnecessary CPU usage since the display only updates every minute. Consider setting interval to 60 seconds or keeping seconds in the format.
Suggested change
| interval = 1; | |
| interval = 60; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.